Hi Thomas,
On Tue, 8 Oct 2019, Johannes Schindelin wrote:
> On Mon, 7 Oct 2019, Thomas Gummerer wrote:
>
> > Subject: [PATCH] range-diff: don't segfault with mode-only changes
> >
> > If we don't have a new file, deleted file or renamed file in a diff,
> > we currently add 'patch.new_name' to the
Hi Thomas,
On Mon, 7 Oct 2019, Thomas Gummerer wrote:
> Subject: [PATCH] range-diff: don't segfault with mode-only changes
>
> If we don't have a new file, deleted file or renamed file in a diff,
> we currently add 'patch.new_name' to the range-diff header. This
> works well for files that are c
Hi Junio,
On Tue, 8 Oct 2019, Junio C Hamano wrote:
> Thomas Gummerer writes:
>
> > We can however rely on 'patch.def_name' in that case, which is
> > extracted from the 'diff --git' line and should be equal to
> > 'patch.new_name'. Use that instead to avoid the segfault.
>
> This patch makes t
Hello Thomas,
On Mon, Oct 07, 2019 at 02:48:31PM +0100, Thomas Gummerer wrote:
> I can hopefully do some more testing and write automated tests later
> today or tomorrow. In the meantime it would be awesome if you could
> confirm if this patch fixes the problem you were seeing.
I assume you alre
Thomas Gummerer writes:
> We can however rely on 'patch.def_name' in that case, which is
> extracted from the 'diff --git' line and should be equal to
> 'patch.new_name'. Use that instead to avoid the segfault.
This patch makes the way this function calls parse_git_diff_header()
more in line wi
On 10/07, Uwe Kleine-König wrote:
> Hello,
>
> With git 2.23.0 I have:
>
> uwe@taurus:~/tmp/rangediff-segfault$ git init
> Initialized empty Git repository in
> /home/uwe/tmp/rangediff-segfault/.git/
> uwe@taurus:~/tmp/rangediff-segfault$ echo root > root
> uwe@taurus:~/t
Hello,
With git 2.23.0 I have:
uwe@taurus:~/tmp/rangediff-segfault$ git init
Initialized empty Git repository in
/home/uwe/tmp/rangediff-segfault/.git/
uwe@taurus:~/tmp/rangediff-segfault$ echo root > root
uwe@taurus:~/tmp/rangediff-segfault$ git add root
7 matches
Mail list logo
