Re: mac test failure -- test 3301

2014-11-11 Thread Johan Herland
On Tue, Nov 11, 2014 at 3:41 AM, Jeff King wrote: > On Tue, Nov 11, 2014 at 02:40:19AM +0100, Johan Herland wrote: >> > This and all other failures are due to the output of 'wc -l', which on >> > Mac is "{whitespace}1" rather than just "1" as it is on other >> > platforms. fbe4f748 added quotes ar

Re: mac test failure -- test 3301

2014-11-11 Thread Junio C Hamano
Johan Herland writes: > Ah, thanks! > > I thought that quoting command output was a good idea in general. Am I > wrong, or is this just one exception to an otherwise good guideline? It is not a good practice to blindly follow any guideline ;-). When you anticipate that different platforms throw

Re: mac test failure -- test 3301

2014-11-10 Thread Jeff King
On Tue, Nov 11, 2014 at 02:40:19AM +0100, Johan Herland wrote: > > This and all other failures are due to the output of 'wc -l', which on > > Mac is "{whitespace}1" rather than just "1" as it is on other > > platforms. fbe4f748 added quotes around the $(... | wc -l) invocation > > which caused the

Re: mac test failure -- test 3301

2014-11-10 Thread Michael Blume
If quoting is generally preferred as a best practice, we could force wc to behave more consistently before we start testing diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 0d93e33..57ed608 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -515,6 +515,14 @@

Re: mac test failure -- test 3301

2014-11-10 Thread Johan Herland
On Tue, Nov 11, 2014 at 2:19 AM, Eric Sunshine wrote: > On Mon, Nov 10, 2014 at 7:17 PM, Michael Blume wrote: >> the commit modernizing test 3301 >> (https://github.com/git/git/commit/fbe4f74865acfd) appears to break it >> on my mac >> >> $ ./t3301-notes.sh -v >> expecting success: >> MSG=b4 git

Re: mac test failure -- test 3301

2014-11-10 Thread Eric Sunshine
On Mon, Nov 10, 2014 at 7:17 PM, Michael Blume wrote: > the commit modernizing test 3301 > (https://github.com/git/git/commit/fbe4f74865acfd) appears to break it > on my mac > > $ ./t3301-notes.sh -v > expecting success: > MSG=b4 git notes add && > test_path_is_missing .git/NOTES_EDITMSG && > test

Re: mac test failure -- test 3301

2014-11-10 Thread Michael Blume
my first thought was that this might be a bash versioning issue, since the commit in question basically refactors the script, and macs ship with an archaic version of bash, but I have the same problem with bash 4.3.30 On Mon, Nov 10, 2014 at 4:23 PM, Michael Blume wrote: > (to be clear: I ran git

Re: mac test failure -- test 3301

2014-11-10 Thread Michael Blume
(to be clear: I ran git bisect, and traced the problem to the modernize commit) On Mon, Nov 10, 2014 at 4:17 PM, Michael Blume wrote: > the commit modernizing test 3301 > (https://github.com/git/git/commit/fbe4f74865acfd) appears to break it > on my mac > > Verbose output follows: > > $ ./t3301-n