Re: Re: cat-file timing window on Cygwin

2017-09-08 Thread Ramsay Jones
On 27/08/17 16:47, Ramsay Jones wrote: > On 27/08/17 12:33, Adam Dinwoodie wrote: [snip] >> Cygwin 2.8.3 hasn't been released yet, > > Heh, yes, I found that out myself this afternoon. ;-) > >> but I've just tested the latest >> development snapshot wit

RE: cat-file timing window on Cygwin

2017-08-27 Thread Jason Pyeron
> -Original Message- > From: Ramsay Jones > Sent: Sunday, August 27, 2017 11:48 AM > To: Adam Dinwoodie > Cc: Jeff King; git@vger.kernel.org; Johannes Schindelin > Subject: Re: cat-file timing window on Cygwin > > > > On 27/08/17 12:33, Adam Dinwoodie wrot

Re: cat-file timing window on Cygwin

2017-08-27 Thread Ramsay Jones
On 27/08/17 12:33, Adam Dinwoodie wrote: > On Sun, Aug 27, 2017 at 03:06:31AM +0100, Ramsay Jones wrote: >> On 26/08/17 22:11, Adam Dinwoodie wrote: >>> On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote: Interesting. I find it a little hard to believe there's so obvious a bug as

Re: cat-file timing window on Cygwin

2017-08-27 Thread Adam Dinwoodie
On Sun, Aug 27, 2017 at 03:06:31AM +0100, Ramsay Jones wrote: > On 26/08/17 22:11, Adam Dinwoodie wrote: > > On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote: > >> Interesting. I find it a little hard to believe there's so obvious a bug > >> as "fflush(NULL) flushes stdin", but well...that

Re: cat-file timing window on Cygwin

2017-08-26 Thread Ramsay Jones
On 26/08/17 22:11, Adam Dinwoodie wrote: > On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote: >> On Sat, Aug 26, 2017 at 01:57:18AM +0100, Ramsay Jones wrote: >> diff --git a/run-command.c b/run-command.c index 98621faca8..064ebd1995 100644 --- a/run-command.c +++ b/ru

Re: cat-file timing window on Cygwin

2017-08-26 Thread Adam Dinwoodie
On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote: > On Sat, Aug 26, 2017 at 01:57:18AM +0100, Ramsay Jones wrote: > > > > diff --git a/run-command.c b/run-command.c > > > index 98621faca8..064ebd1995 100644 > > > --- a/run-command.c > > > +++ b/run-command.c > > > @@ -641,7 +641,6 @@ int

Re: cat-file timing window on Cygwin

2017-08-26 Thread Jeff King
On Sat, Aug 26, 2017 at 01:57:18AM +0100, Ramsay Jones wrote: > > diff --git a/run-command.c b/run-command.c > > index 98621faca8..064ebd1995 100644 > > --- a/run-command.c > > +++ b/run-command.c > > @@ -641,7 +641,6 @@ int start_command(struct child_process *cmd) > > } > > > > trace_ar

Re: cat-file timing window on Cygwin

2017-08-26 Thread Adam Dinwoodie
On Sat, Aug 26, 2017 at 01:57:18AM +0100, Ramsay Jones wrote: > On 25/08/17 16:08, Jeff King wrote: > > On Fri, Aug 25, 2017 at 12:25:29PM +0100, Adam Dinwoodie wrote: > > > >> As of v2.10.0-rc1-4-g321459439 ("cat-file: support --textconv/--filters > >> in batch mode"), t8010-cat-file-filters.sh h

Re: cat-file timing window on Cygwin

2017-08-25 Thread Ramsay Jones
On 25/08/17 16:08, Jeff King wrote: > On Fri, Aug 25, 2017 at 12:25:29PM +0100, Adam Dinwoodie wrote: > >> As of v2.10.0-rc1-4-g321459439 ("cat-file: support --textconv/--filters >> in batch mode"), t8010-cat-file-filters.sh has been failing on Cygwin. >> Digging into this, the test looks to exp

Re: cat-file timing window on Cygwin

2017-08-25 Thread Jeff King
On Fri, Aug 25, 2017 at 12:25:29PM +0100, Adam Dinwoodie wrote: > As of v2.10.0-rc1-4-g321459439 ("cat-file: support --textconv/--filters > in batch mode"), t8010-cat-file-filters.sh has been failing on Cygwin. > Digging into this, the test looks to expose a timing window: it appears > that if `gi