Re: My patches

2013-10-18 Thread Junio C Hamano
Theodore Ts'o writes: > Over the past 5+ years, I've observed that I > think the way commit selection in "git format-patch" is inconsistent > with how we handle commit selection for other commands, e.g., "git log > " vs and "git format-patch ". Even if you think that > this is a matter of self-i

Re: My patches

2013-10-18 Thread Felipe Contreras
Theodore Ts'o wrote: > On Fri, Oct 18, 2013 at 06:41:41AM -0500, Felipe Contreras wrote: > > > And I hazard to guess that the vast majority agree with Junio on this > > > (based, > > > again, on email evidence). Not with you. > > > > That is irrelevant, and a fallacy. The vast majority of people

Re: My patches

2013-10-18 Thread Theodore Ts'o
On Fri, Oct 18, 2013 at 06:41:41AM -0500, Felipe Contreras wrote: > > And I hazard to guess that the vast majority agree with Junio on this > > (based, > > again, on email evidence). Not with you. > > That is irrelevant, and a fallacy. The vast majority of people thought the > Earth was the cente

Re: My patches

2013-10-18 Thread Felipe Contreras
Max Horn wrote: > I guess most other people keep out of this because they are sensible enough > to not feed the troll, and instead focus on useful things. But I can't help > it, I have to say this. You should probably read the definition of troll: https://en.wikipedia.org/wiki/Troll_(Internet) U

Re: My patches

2013-10-18 Thread Max Horn
I guess most other people keep out of this because they are sensible enough to not feed the troll, and instead focus on useful things. But I can't help it, I have to say this. On 17.10.2013, at 23:44, Felipe Contreras wrote: > Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> Junio C

Re: My patches

2013-10-17 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > Junio C Hamano wrote: > >> Such a review comment and the discussion that follows it after a > >> patch is posted is an essential part of the collaborative > >> development process in this community and it has helped the quality > >> of our en

Re: My patches

2013-10-17 Thread Junio C Hamano
Felipe Contreras writes: > Junio C Hamano wrote: >> Such a review comment and the discussion that follows it after a >> patch is posted is an essential part of the collaborative >> development process in this community and it has helped the quality >> of our end product. We unfortunately saw time

Re: My patches

2013-10-14 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > Clearly, a lot of my patches have not been reviewed ... > > I think the reason for it most likely is because you earned the Bozo > bit ($gmane/227602) in many reviewers' eyes. So what you are saying is that the reason is entirely personal,

Re: My patches

2013-10-14 Thread Junio C Hamano
Felipe Contreras writes: > Clearly, a lot of my patches have not been reviewed ... I think the reason for it most likely is because you earned the Bozo bit ($gmane/227602) in many reviewers' eyes. I phrased it differently ($gmane/233347) at the beginning of this cycle, but I'll say it one more

Re: My patches

2013-10-12 Thread Felipe Contreras
On Sat, Oct 12, 2013 at 11:18 AM, Philip Oakley wrote: > From: "Felipe Contreras" > Sent: Saturday, October 12, 2013 8:24 AM >> Clearly, a lot of my patches have not been reviewed properly, so even >> though they are technically correct, and would benefit users, some have >> specifically been re

Re: My patches

2013-10-12 Thread Philip Oakley
From: "Felipe Contreras" Sent: Saturday, October 12, 2013 8:24 AM Hi, Clearly, a lot of my patches have not been reviewed properly, so even though they are technically correct, and would benefit users, some have specifically been requested by them, and at least one would significantly improve