Re: Re: Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Pickfire
Jacob Keller wrote: > On Tue, Mar 28, 2017 at 10:53 AM, Pickfire wrote: > > > > Yes, I can't reproduce it outside the test suite. I have added the builtin > > and yet the test fails. test_decode_color gets same output as expect but > > still it fails, should I send in the patch? > > You also ne

Re: Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Pickfire
Stefan Beller wrote: > On Tue, Mar 28, 2017 at 3:46 AM, Pickfire wrote: > > > EOF > > > > echo '* diff="cpp"' > .gitmodules > > Did you mean .gitattributes? Yeah, that's a spelling error.

Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Stefan Beller
On Tue, Mar 28, 2017 at 3:46 AM, Pickfire wrote: > EOF > > echo '* diff="cpp"' > .gitmodules Did you mean .gitattributes?

Re: Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Jacob Keller
On Tue, Mar 28, 2017 at 10:53 AM, Pickfire wrote: > > Yes, I can't reproduce it outside the test suite. I have added the builtin > and yet the test fails. test_decode_color gets same output as expect but > still it fails, should I send in the patch? You also need to ensure you have the exact same

Re: Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Pickfire
Jacob Keller wrote: > On Tue, Mar 28, 2017 at 3:46 AM, Pickfire wrote: > > While I was working buildins shell patterns for user diffs. I noticed that > > the tests t4034 passes but I can reproduce it manually with: > > > > mkdir cpp/ && cd cpp/ && git init > > > > cat > pre < > Foo()

Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Jacob Keller
On Tue, Mar 28, 2017 at 3:46 AM, Pickfire wrote: > While I was working buildins shell patterns for user diffs. I noticed that > the tests t4034 passes but I can reproduce it manually with: > > mkdir cpp/ && cd cpp/ && git init > > cat > pre < Foo():x(0&&1){} > cout<<"Hello World!\n