Re: Incorrect diff-parseopt conversion?

2019-05-25 Thread Duy Nguyen
On Fri, May 24, 2019 at 5:08 PM Ævar Arnfjörð Bjarmason wrote: > >> OK, I just had a look at the code in parse-options.c. > >> Hmm, somewhat ugly! :-D > > > > Yeah it's a bit hackish. The problem is parse-options (and also config > > parser) does not allow passing user data to the callback. Changi

Re: Incorrect diff-parseopt conversion?

2019-05-24 Thread Ævar Arnfjörð Bjarmason
On Fri, May 24 2019, Duy Nguyen wrote: > On Wed, May 22, 2019 at 7:35 AM Ramsay Jones > wrote: >> >> >> >> On 22/05/2019 01:11, Duy Nguyen wrote: >> > On Wed, May 22, 2019 at 2:56 AM Ramsay Jones >> > wrote: >> >> >> >> Hi Duy, >> >> >> >> I am in the middle of rebasing a long running branch o

Re: Incorrect diff-parseopt conversion?

2019-05-24 Thread Duy Nguyen
On Wed, May 22, 2019 at 7:35 AM Ramsay Jones wrote: > > > > On 22/05/2019 01:11, Duy Nguyen wrote: > > On Wed, May 22, 2019 at 2:56 AM Ramsay Jones > > wrote: > >> > >> Hi Duy, > >> > >> I am in the middle of rebasing a long running branch onto > >> current master (v2.22.0-rc1) and noticed someth

Re: Incorrect diff-parseopt conversion?

2019-05-21 Thread Ramsay Jones
On 22/05/2019 01:11, Duy Nguyen wrote: > On Wed, May 22, 2019 at 2:56 AM Ramsay Jones > wrote: >> >> Hi Duy, >> >> I am in the middle of rebasing a long running branch onto >> current master (v2.22.0-rc1) and noticed something odd with >> commit af2f368091 ("diff-parseopt: convert --output-*",

Re: Incorrect diff-parseopt conversion?

2019-05-21 Thread Duy Nguyen
On Wed, May 22, 2019 at 2:56 AM Ramsay Jones wrote: > > Hi Duy, > > I am in the middle of rebasing a long running branch onto > current master (v2.22.0-rc1) and noticed something odd with > commit af2f368091 ("diff-parseopt: convert --output-*", > 2019-02-21). > > As part of the branch I am rebasi

Re: Incorrect Diff!

2017-06-01 Thread Junio C Hamano
Pulkit Goyal <7895pul...@gmail.com> writes: > I was working on a Django project when I got the following diff which > is very much confusing. > > The diff is pasted at https://bpaste.net/show/c2cb00728ff0. > > As you can see on bpaste that in line number 9,10 I have changed > "class activationview