Re: GSoC Project | Improvise git bisect

2016-03-21 Thread Pranit Bauva
On Mon, Mar 21, 2016 at 11:23 PM, Christian Couder wrote: > Hi Pranit, > > On Mon, Mar 21, 2016 at 8:29 AM, Pranit Bauva wrote: >> On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin >> wrote: >>> Hi Pranit, >>> >>> On Sun, 20 Mar 2016, Pranit Bauva wrote: >>> I could first move individua

Re: GSoC Project | Improvise git bisect

2016-03-21 Thread Christian Couder
Hi Pranit, On Mon, Mar 21, 2016 at 8:29 AM, Pranit Bauva wrote: > On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin > wrote: >> Hi Pranit, >> >> On Sun, 20 Mar 2016, Pranit Bauva wrote: >> >>> I could first move individual functions to bisect--helper.c. >> >> My suggestion would be to give i

Re: GSoC Project | Improvise git bisect

2016-03-21 Thread Pranit Bauva
On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin wrote: > Hi Pranit, > > On Sun, 20 Mar 2016, Pranit Bauva wrote: > >> I could first move individual functions to bisect--helper.c. > > My suggestion would be to give it a try already with some functionality > you deem small enough to move to th

Re: GSoC Project | Improvise git bisect

2016-03-21 Thread Johannes Schindelin
Hi Pranit, On Sun, 20 Mar 2016, Pranit Bauva wrote: > I could first move individual functions to bisect--helper.c. My suggestion would be to give it a try already with some functionality you deem small enough to move to the bisect--helper within a day or so. It is always good to test the waters

Re: GSoC Project | Improvise git bisect

2016-03-20 Thread Matthieu Moy
Pranit Bauva writes: > When I am writing > functions, I am thinking to make some tests which will be copied > contents of t/t6030-bisect-porcelain.sh with s/bisect/bisect--helper/g > uncommenting tests as I implement more functions. I don't think you need that. When you write a new function, you

Re: GSoC Project | Improvise git bisect

2016-03-20 Thread Pranit Bauva
I didn't mention it before, I was thinking to move directly everything from git-bisect.sh to bisect.c . But then I would have to redirect to a shell script. And ultimately remove bisect--helper.c Your suggestions is a lot better. I could first move individual functions to bisect--helper.c. This wo

Re: GSoC Project | Improvise git bisect

2016-03-20 Thread Johannes Schindelin
Hi, On Sun, 20 Mar 2016, Pranit Bauva wrote: > The plan: > > - Place bisect.c in builtin/ > - Implement a skeletal cmd_bisect() which will redirect to > git-bisect.sh (1e1ea69f) I would highly advise a different course of action: - move functionality one by one from bisect.sh to builtin/bise

Re: GSoC Project | Improvise git bisect

2016-03-20 Thread Matthieu Moy
Pranit Bauva writes: > The project Idea: Incremental Rewrite from shell to C of git-bisect.sh > > The plan: > > - Place bisect.c in builtin/ > - Implement a skeletal cmd_bisect() which will redirect to > git-bisect.sh (1e1ea69f) > - Introduce a structure for parsing the command line flags. >

Re: GSoC Project | Improvise git bisect

2016-03-20 Thread Christian Couder
On Sun, Mar 20, 2016 at 12:35 PM, Pranit Bauva wrote: > The project Idea: Incremental Rewrite from shell to C of git-bisect.sh > > The plan: > > - Place bisect.c in builtin/ > - Implement a skeletal cmd_bisect() which will redirect to > git-bisect.sh (1e1ea69f) > - Introduce a structure for par

Re: GSoC Project | Improvise git bisect

2016-03-20 Thread Pranit Bauva
The project Idea: Incremental Rewrite from shell to C of git-bisect.sh The plan: - Place bisect.c in builtin/ - Implement a skeletal cmd_bisect() which will redirect to git-bisect.sh (1e1ea69f) - Introduce a structure for parsing the command line flags. - Start converting individual functions

Re: GSoC Project | Improvise git bisect

2016-03-20 Thread Pranit Bauva
On Sun, Mar 20, 2016 at 3:35 AM, Stefan Beller wrote: > Once upon a time, a discussion produced this proposal[1], > which tries to split up the set as good as possible (50:50) instead > of inspecting the branch/merging structure of the underlying graph. > Thanks! This helped me in getting to know

Re: GSoC Project | Improvise git bisect

2016-03-19 Thread Stefan Beller
On 19.03.2016 09:49, Pranit Bauva wrote: > On Sat, Mar 19, 2016 at 9:44 PM, Christian Couder > wrote: >> Hi, >> >> On Sat, Mar 19, 2016 at 1:48 PM, Matthieu Moy >> wrote: >>>> Subject: Re: GSoC Project | Improvise git bisect >>>

Re: GSoC Project | Improvise git bisect

2016-03-19 Thread Pranit Bauva
On Sat, Mar 19, 2016 at 9:44 PM, Christian Couder wrote: > Hi, > > On Sat, Mar 19, 2016 at 1:48 PM, Matthieu Moy > wrote: >>> Subject: Re: GSoC Project | Improvise git bisect >> >> >> "Improve" I guess

Re: GSoC Project | Improvise git bisect

2016-03-19 Thread Christian Couder
Hi, On Sat, Mar 19, 2016 at 1:48 PM, Matthieu Moy wrote: >> Subject: Re: GSoC Project | Improvise git bisect > > > "Improve" I guess. > > Pranit Bauva writes: > >> Hey everyone! > > Hi, > >> Wha

Re: GSoC Project | Improvise git bisect

2016-03-19 Thread Matthieu Moy
> Subject: Re: GSoC Project | Improvise git bisect "Improve" I guess. Pranit Bauva writes: > Hey everyone! Hi, > What I understood is that let's say the repository is like : > > C13 >| >