Re: [v3 PATCH 2/2] reset: add tests for git reset -

2015-03-20 Thread Kevin D
On Fri, Mar 20, 2015 at 04:02:38AM +0530, Sundararajan R wrote: > Yes. I made a mistake while framing the sentence. I should have proof read > the commit message more thoroughly. Should I submit a new patch with the > corrected commit message? Yeah, you can combine that with the comments from Mat

Re: [v3 PATCH 2/2] reset: add tests for git reset -

2015-03-19 Thread Kevin D
On Wed, Mar 18, 2015 at 02:05:09PM +0530, Sundararajan R wrote: > The failure case which occurs on teaching git is taught the '-' shorthand > is when there exists no branch pointed to by '@{-1}'. But, if there is a file > named - in the working tree, the user can be unambiguously assumed to be > r

Re: [v3 PATCH 2/2] reset: add tests for git reset -

2015-03-18 Thread Matthieu Moy
Sundararajan R writes: > Subject: [v3 PATCH 2/2] reset: add tests for git reset - This should be [PATCH v3 2/2]. "git send-email -v2" can do this for you. Sundararajan R writes: > +test_expect_success 'reset - with no @{-1} branch and file named - should > succeed' ' > + test_when_finis