Re: [RFC PATCH 0/7] Moved code detection: ignore space on uniform indentation

2018-04-03 Thread Jacob Keller
On Tue, Apr 3, 2018 at 12:00 PM, Stefan Beller wrote: The fun is in the last patch, which allows white space sensitive languages to trust the move detection, too. Each block that is marked as moved will have the same delta in {in-, de-}dentation. I would think this mode might b

Re: [RFC PATCH 0/7] Moved code detection: ignore space on uniform indentation

2018-04-03 Thread Stefan Beller
>>> The fun is in the last patch, which allows white space sensitive >>> languages to trust the move detection, too. Each block that is marked as >>> moved will have the same delta in {in-, de-}dentation. >>> I would think this mode might be a reasonable default eventually. >> >> This sounds like a

Re: [RFC PATCH 0/7] Moved code detection: ignore space on uniform indentation

2018-04-02 Thread Jacob Keller
On Mon, Apr 2, 2018 at 4:47 PM, Jonathan Tan wrote: > On Mon, 2 Apr 2018 15:48:47 -0700 > Stefan Beller wrote: > >> This is a re-attempt of [1], which allows the moved code detection to >> ignore blanks in various modes. >> >> patches 1-5 are refactoring, patch 6 adds all existing white space op

Re: [RFC PATCH 0/7] Moved code detection: ignore space on uniform indentation

2018-04-02 Thread Jonathan Tan
On Mon, 2 Apr 2018 15:48:47 -0700 Stefan Beller wrote: > This is a re-attempt of [1], which allows the moved code detection to > ignore blanks in various modes. > > patches 1-5 are refactoring, patch 6 adds all existing white space options > of regular diff to the move detection. (I am unsure a