Re: [RFC PATCH] Revamp git-cherry(1)

2013-11-21 Thread Junio C Hamano
Thomas Rast writes: > Junio C Hamano writes: > >>> OPTIONS >>> --- >>> -v:: >>> - Verbose. >>> + Verbose. Currently shows the commit subjects next to their >>> + SHA1. >> >> Whenever I see "Currently", it makes me wonder "why does it need to >> say that? Is there a plan to change i

Re: [RFC PATCH] Revamp git-cherry(1)

2013-11-21 Thread Thomas Rast
Junio C Hamano writes: >> OPTIONS >> --- >> -v:: >> -Verbose. >> +Verbose. Currently shows the commit subjects next to their >> +SHA1. > > Whenever I see "Currently", it makes me wonder "why does it need to > say that? Is there a plan to change it soon, and if so where is the

Re: [RFC PATCH] Revamp git-cherry(1)

2013-11-21 Thread Thomas Rast
Jeff King writes: > On Thu, Nov 21, 2013 at 12:30:56PM +0100, Thomas Rast wrote: > >> +Later, you can whether your changes have been applied by saying (still >> +on `topic`): > > s/can/& see/ ? > >> +Note that this uses , and assumes that >> +`core.autosetupmerge` is enabled (the default). > > I

Re: [RFC PATCH] Revamp git-cherry(1)

2013-11-21 Thread Junio C Hamano
Thomas Rast writes: > NAME > > -git-cherry - Find commits not merged upstream > +git-cherry - Find commits not applied in upstream Good. > +Determine whether there are commits in `..` that are > +equivalent to those in the range `..`. > > +The equivalence test is based on the diff, aft

Re: [RFC PATCH] Revamp git-cherry(1)

2013-11-21 Thread Jeff King
On Thu, Nov 21, 2013 at 12:30:56PM +0100, Thomas Rast wrote: > git-cherry(1)'s "description" section has never really managed to > explain to me what the command does. It contains too much explanation > of the algorithm instead of simply saying what goals it achieves, and > too much terminology t