Re: [RFC] column: show auto columns when pager is active

2017-10-12 Thread Jeff King
On Wed, Oct 11, 2017 at 06:54:04AM +0200, Kevin Daudt wrote: > > > Yeah, I didn't think of that with respect to the pager. This is a > > > regression in v2.14.2, I think. > > > > Yes. > > Though 2.14.2 enabled the pager by default, even before that when > someone would've enabled the pager their

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Kevin Daudt
On Tue, Oct 10, 2017 at 07:02:00PM +0200, Martin Ågren wrote: > On 10 October 2017 at 16:01, Jeff King wrote: > > On Tue, Oct 10, 2017 at 12:30:49PM +0200, Martin Ågren wrote: > >> On 9 October 2017 at 23:45, Kevin Daudt wrote: > >> > Since ff1e72483 (tag: change default of `pager.tag` to "on", >

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Kevin Daudt
On Tue, Oct 10, 2017 at 07:04:42PM +0200, Martin Ågren wrote: > On 10 October 2017 at 16:29, Jeff King wrote: > > On Tue, Oct 10, 2017 at 10:10:19AM -0400, Jeff King wrote: > > > > it will randomly succeed or fail, depending on whether sed manages to > > read the input before the stdin terminal is

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Martin Ågren
On 10 October 2017 at 16:29, Jeff King wrote: > On Tue, Oct 10, 2017 at 10:10:19AM -0400, Jeff King wrote: > > it will randomly succeed or fail, depending on whether sed manages to > read the input before the stdin terminal is closed. > > I'm not sure of an easy way to fix test-terminal, but we co

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Martin Ågren
On 10 October 2017 at 16:01, Jeff King wrote: > On Tue, Oct 10, 2017 at 12:30:49PM +0200, Martin Ågren wrote: >> On 9 October 2017 at 23:45, Kevin Daudt wrote: >> > Since ff1e72483 (tag: change default of `pager.tag` to "on", >> > 2017-08-02), the pager has been enabled by default, exposing this

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Jeff King
On Tue, Oct 10, 2017 at 10:10:19AM -0400, Jeff King wrote: > That said, I'm still puzzled why it would return zero output. Strace > shows that the read from stdin is getting no input. I suspect this may > have to do with how we redirect stdin in test-terminal.perl. > > See 18d8c26930 (test_termin

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Jeff King
On Mon, Oct 09, 2017 at 11:45:43PM +0200, Kevin Daudt wrote: > +test_expect_success TTY '20 columns, mode auto, pager' ' > + cat >expected <<\EOF && > +oneseven > +twoeight > +three nine > +four ten > +five eleven > +six > +EOF > + test_terminal env PAGER="cat|cat" git column

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Jeff King
On Tue, Oct 10, 2017 at 12:30:49PM +0200, Martin Ågren wrote: > On 9 October 2017 at 23:45, Kevin Daudt wrote: > > When columns are set to automatic for git tag and the output is > > paginated by git, the output is a single column instead of multiple > > columns. > > > > Standard behaviour in git

Re: [RFC] column: show auto columns when pager is active

2017-10-10 Thread Martin Ågren
On 9 October 2017 at 23:45, Kevin Daudt wrote: > When columns are set to automatic for git tag and the output is > paginated by git, the output is a single column instead of multiple > columns. > > Standard behaviour in git is to honor auto values when the pager is > active, which happens for exam

Re: [RFC] column: show auto columns when pager is active

2017-10-09 Thread Eric Sunshine
On Mon, Oct 9, 2017 at 5:45 PM, Kevin Daudt wrote: > When columns are set to automatic for git tag and the output is > paginated by git, the output is a single column instead of multiple > columns. > > Standard behaviour in git is to honor auto values when the pager is > active, which happens for