Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-04 Thread Luis Henriques
On Thu, Dec 04, 2014 at 11:33:24AM -0800, Junio C Hamano wrote: > Luis Henriques writes: > > > On Wed, Dec 03, 2014 at 08:56:45AM -0800, Junio C Hamano wrote: > > > >> I actually do not think this is a good idea from debuggability. > > > > Do you think this could be merged with yet another switch

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-04 Thread Junio C Hamano
Luis Henriques writes: > On Wed, Dec 03, 2014 at 08:56:45AM -0800, Junio C Hamano wrote: > >> I actually do not think this is a good idea from debuggability. > > Do you think this could be merged with yet another switch? I can't > think of a name for the switch, something like... "--hide-msgid"?

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-04 Thread Luis Henriques
On Wed, Dec 03, 2014 at 08:56:45AM -0800, Junio C Hamano wrote: > Eric Wong writes: > > > Luis Henriques wrote: > >> On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: > >> > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' > >> > header to the email being sen

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Luis Henriques
On Wed, Dec 03, 2014 at 09:23:11AM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > Two problems here. > > ... > > tests? > > Something like this squashed into the patch you posted earlier, > perhaps, would be a good place to start. > Awesome, thank you for your review. I'll post a

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Junio C Hamano
Junio C Hamano writes: > @@ -177,8 +177,7 @@ sub format_2822_time { > my $multiedit; > my $editor; > > -# Usage of X-Mailer email header > -my $xmailer; > +my $use_xmailer; Just another small thing. The version of "SQUASH???" commit I will queue on 'pu' will have this next to where $annotat

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Junio C Hamano
Junio C Hamano writes: > Two problems here. > ... > tests? Something like this squashed into the patch you posted earlier, perhaps, would be a good place to start. Documentation/git-send-email.txt | 6 -- git-send-email.perl | 11 +-- 2 files changed, 9 insertions(+),

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Junio C Hamano
Luis Henriques writes: > +--xmailer:: > + Prevent adding the "X-Mailer:" header. Default value is > + 'sendemail.xmailer'. Two problems here. - "git send-email --xmailer" would _ADD_, not prevent adding, the header, regardless of the value of sendemail.xmailer. - It is unspecifie

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Junio C Hamano
Eric Wong writes: > Luis Henriques wrote: >> On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: >> > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' >> > header to the email being sent. >> > >> >> Ping >> >> It's been a while since I sent this patch. Is th

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Luis Henriques
On Tue, Dec 02, 2014 at 07:22:10PM -0800, Kyle J. McKay wrote: > On Dec 2, 2014, at 18:34, Eric Wong wrote: > > >Luis Henriques wrote: > >>On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: > >>>Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' > >>>header to th

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-02 Thread Kyle J. McKay
On Dec 2, 2014, at 18:34, Eric Wong wrote: Luis Henriques wrote: On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: Add --[no-]xmailer that allows a user to disable adding the 'X- Mailer:' header to the email being sent. Ping It's been a while since I sent this patch. Is th

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-02 Thread Eric Wong
Luis Henriques wrote: > On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: > > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' > > header to the email being sent. > > > > Ping > > It's been a while since I sent this patch. Is there any interest in > having t

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-02 Thread Luis Henriques
On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' > header to the email being sent. > Ping It's been a while since I sent this patch. Is there any interest in having this switch in git-send-email? I honestly