Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-06-04 Thread Junio C Hamano
Jeff King writes: > We should definitely _not_ add anything that scales with the repository > size. For instance, the "symref" field only shows the "HEAD" now. That's > OK, as it's constant size. I agree that this is an easy-to-explain rule to keep the design sensible. > We do not show _all_ sy

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-06-04 Thread Jeff King
On Mon, Jun 01, 2015 at 04:40:54PM -0700, Stefan Beller wrote: > Thinking about this further, maybe it is a good idea to restrict the > capabilities advertising to alphabetical order? This seems like an unnecessary restriction. The main impetus seems to be: > So how does parse_capability scale w

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-06-02 Thread Junio C Hamano
Stefan Beller writes: > I think the recent issue with the push certificates shows that having > arbitrary > data after the = is a bad idea. I do not think push certificate episode tells any such thing. It was about not carefully using cryptography with arbitrary data. How that arbitrary data c

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-06-01 Thread Stefan Beller
On Mon, Jun 1, 2015 at 4:14 PM, Stefan Beller wrote: > On Fri, May 29, 2015 at 3:21 PM, Jeff King wrote: >> On Fri, May 29, 2015 at 02:52:14PM -0700, Junio C Hamano wrote: >> >>> > Currently we can do a = as part of the line after the first ref, such as >>> > >>> > symref=HEAD:refs/heads/mast

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-06-01 Thread Stefan Beller
On Fri, May 29, 2015 at 3:21 PM, Jeff King wrote: > On Fri, May 29, 2015 at 02:52:14PM -0700, Junio C Hamano wrote: > >> > Currently we can do a = as part of the line after the first ref, such as >> > >> > symref=HEAD:refs/heads/master agent=git/2:2.4.0 >> > >> > so I thought we want to keep t

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-05-29 Thread Jeff King
On Fri, May 29, 2015 at 02:52:14PM -0700, Junio C Hamano wrote: > > Currently we can do a = as part of the line after the first ref, such as > > > > symref=HEAD:refs/heads/master agent=git/2:2.4.0 > > > > so I thought we want to keep this. > > I do not understand that statement. > > Capabili

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-05-29 Thread Junio C Hamano
Stefan Beller writes: >>> +Capability discovery (v2) >>> +- >>> ... >>> + capability-list = *(capability) [agent LF] flush-pkt >>> + capability = PKT-LINE("capability:" keyvaluepair LF) >>> + agent= keyvaluepair LF >>> + keyvaluepair = 1*(LC_

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-05-29 Thread Stefan Beller
On Fri, May 29, 2015 at 1:35 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> @@ -1,11 +1,11 @@ >> Packfile transfer protocols >> === >> >> -Git supports transferring data in packfiles over the ssh://, git:// and >> +Git supports transferring data in packfiles over

Re: [RFC/WIP PATCH 11/11] Document protocol version 2

2015-05-29 Thread Junio C Hamano
Stefan Beller writes: > @@ -1,11 +1,11 @@ > Packfile transfer protocols > === > > -Git supports transferring data in packfiles over the ssh://, git:// and > +Git supports transferring data in packfiles over the ssh://, git://, http:// > and When you have chance, can