Re: [RFC/PATCHv2] Makefile: add cppcheck target

2016-12-16 Thread Chris Packham
On Fri, Dec 16, 2016 at 9:28 PM, Lars Schneider wrote: > > On 14 Dec 2016, at 12:24, Jeff King wrote: > > On Wed, Dec 14, 2016 at 10:27:31PM +1300, Chris Packham wrote: > > Changes in v2: > > - only run over actual git source files. > > - omit any files in t/ > > > I actually wonder if FIND_SOURC

Re: [RFC/PATCHv2] Makefile: add cppcheck target

2016-12-14 Thread Jeff King
On Wed, Dec 14, 2016 at 06:24:01AM -0500, Jeff King wrote: > On Wed, Dec 14, 2016 at 10:27:31PM +1300, Chris Packham wrote: > > > Changes in v2: > > - only run over actual git source files. > > - omit any files in t/ > > I actually wonder if FIND_SOURCE_FILES should be taking care of the "t/" >

Re: [RFC/PATCHv2] Makefile: add cppcheck target

2016-12-14 Thread Jeff King
On Wed, Dec 14, 2016 at 10:27:31PM +1300, Chris Packham wrote: > Changes in v2: > - only run over actual git source files. > - omit any files in t/ I actually wonder if FIND_SOURCE_FILES should be taking care of the "t/" thing. I think "make tags" finds tags in t4051/appended1.c, which is just si