Re: [RFC/PATCH v4 2/3] add trace_performance facility to debug performance issues

2014-05-21 Thread Jeff King
On Wed, May 21, 2014 at 08:34:47PM +0200, Karsten Blees wrote: > Macros are mainly used to supply __FILE__ and __LINE__, so that lazy > people don't need to think of a unique message for each use of > trace_performance_*. Without __FILE__, __LINE__ and message, the > output would be pretty useless

Re: [RFC/PATCH v4 2/3] add trace_performance facility to debug performance issues

2014-05-21 Thread Karsten Blees
Am 21.05.2014 18:58, schrieb Jeff King: > On Tue, May 20, 2014 at 09:11:19PM +0200, Karsten Blees wrote: > >> Add trace_performance and trace_performance_since macros that print file >> name, line number, time and an optional printf-formatted text to the file >> specified in environment variable G

Re: [RFC/PATCH v4 2/3] add trace_performance facility to debug performance issues

2014-05-21 Thread Jeff King
On Tue, May 20, 2014 at 09:11:19PM +0200, Karsten Blees wrote: > Add trace_performance and trace_performance_since macros that print file > name, line number, time and an optional printf-formatted text to the file > specified in environment variable GIT_TRACE_PERFORMANCE. > > Unless enabled via G