Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-23 Thread Jeff King
On Mon, Sep 23, 2019 at 01:19:18PM +0200, Christian Schoenebeck wrote: > > if (cmit_fmt_is_mail(pp->fmt)) { > > - if (pp->from_ident && ident_cmp(pp->from_ident, &ident)) { > > + if (pp->always_use_in_body_from || > > + (pp->from_ident && ident_cmp(pp->from_id

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-23 Thread Christian Schoenebeck
On Montag, 9. September 2019 16:25:12 CEST Jeff King wrote: > On Mon, Sep 09, 2019 at 09:05:45AM -0500, Eric Blake wrote: > > > But as you can already read from the manual, the overall behaviour of > > > git > > > regarding a separate "From:" line in the email body was intended solely > > > for > >

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Junio C Hamano
Eric Blake writes: > How hard would it be to improve 'git format-patch'/'git send-email' to > have an option to ALWAYS output a From: line in the body, even when the > sender is the author, for the case of a mailing list that munges the > mail headers due to DMARC/DKIM reasons? I'd say that it s

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Jeff King
On Mon, Sep 09, 2019 at 09:05:45AM -0500, Eric Blake wrote: > > But as you can already read from the manual, the overall behaviour of git > > regarding a separate "From:" line in the email body was intended solely for > > the use case sender != author. So in practice (at least in my git version)

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Eric Blake
[adding git list] On 9/5/19 7:25 AM, Christian Schoenebeck wrote: > How are you sending patches ? With git send-email ? If so, maybe you > can > pass something like --from='"Christian Schoenebeck" > '. Since this is a different string, git will > assume you're sending someone