Re: [PATCHv5 9/9] t3301: Modernize

2014-11-12 Thread Johan Herland
On Wed, Nov 12, 2014 at 10:18 PM, Junio C Hamano wrote: > Johan Herland writes: >> On Wed, Nov 12, 2014 at 2:57 AM, Eric Sunshine >> wrote: >>> On Tue, Nov 11, 2014 at 7:40 PM, Johan Herland wrote: + test_line_count = 1 actual >>> >>> Broken &&-chain. This problem is repeated each p

Re: [PATCHv5 9/9] t3301: Modernize

2014-11-12 Thread Junio C Hamano
Johan Herland writes: > On Wed, Nov 12, 2014 at 2:57 AM, Eric Sunshine > wrote: >> On Tue, Nov 11, 2014 at 7:40 PM, Johan Herland wrote: >>> + test_line_count = 1 actual >> >> Broken &&-chain. This problem is repeated each place use invoke >> test_line_count(). > > Thanks. Fixed in the n

Re: [PATCHv5 9/9] t3301: Modernize

2014-11-12 Thread Johan Herland
On Wed, Nov 12, 2014 at 2:57 AM, Eric Sunshine wrote: > On Tue, Nov 11, 2014 at 7:40 PM, Johan Herland wrote: >> + test_line_count = 1 actual > > Broken &&-chain. This problem is repeated each place use invoke > test_line_count(). Thanks. Fixed in the next iteration. ...Johan -- Johan H

Re: [PATCHv5 9/9] t3301: Modernize

2014-11-11 Thread Eric Sunshine
On Tue, Nov 11, 2014 at 7:40 PM, Johan Herland wrote: > Make this test script appear somewhat less old-fashioned: > Signed-off-by: Johan Herland > --- > diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh > index 416ed9e..861c159 100755 > --- a/t/t3301-notes.sh > +++ b/t/t3301-notes.sh > @@ -50,206