Re: [PATCHv3 2/3] mailmap: use higher level string list functions

2014-11-30 Thread Stefan Beller
On 30.11.2014 16:47, Junio C Hamano wrote: > Eric Sunshine writes: > >> On Thu, Nov 27, 2014 at 1:44 PM, Michael Blume wrote: >>> The variable index seems to be unused/uninitialized now -- it's still >>> printed in debug messages, but if I'm reading correctly, its contents are >>> going to be no

Re: [PATCHv3 2/3] mailmap: use higher level string list functions

2014-11-30 Thread Junio C Hamano
Eric Sunshine writes: > On Thu, Nov 27, 2014 at 1:44 PM, Michael Blume wrote: >> The variable index seems to be unused/uninitialized now -- it's still >> printed in debug messages, but if I'm reading correctly, its contents are >> going to be nonsense. > > Nice catch. Let's do something like th

Re: [PATCHv3 2/3] mailmap: use higher level string list functions

2014-11-27 Thread Eric Sunshine
On Thu, Nov 27, 2014 at 1:44 PM, Michael Blume wrote: > The variable index seems to be unused/uninitialized now -- it's still > printed in debug messages, but if I'm reading correctly, its contents are > going to be nonsense. Nice catch. (Aside: Please don't top-post on this list [1].) [1]: htt