Re: [PATCHv2] commit: reword --author error message

2015-01-27 Thread Ramsay Jones
On 26/01/15 19:07, Jeff King wrote: > On Mon, Jan 26, 2015 at 04:48:33PM +0100, Michael J Gruber wrote: > >> -die(_("No existing author found with '%s'"), name); >> +die(_("--author '%s': neither 'Name ' nor a match for an >> existing author"), name); > > I had to add to the bikeshed, bu

Re: [PATCHv2] commit: reword --author error message

2015-01-27 Thread Philip Oakley
From: "Jeff King" On Mon, Jan 26, 2015 at 06:43:46PM -0800, Junio C Hamano wrote: Jeff King writes: > ... I somehow had trouble making > sense of Z ("a match...") as a noun. > I wonder if adding back in the missing verb, rather than a colon, > would > also make more sense: > > --author

Re: [PATCHv2] commit: reword --author error message

2015-01-26 Thread Jeff King
On Mon, Jan 26, 2015 at 06:43:46PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > ... I somehow had trouble making > > sense of Z ("a match...") as a noun. > > > I wonder if adding back in the missing verb, rather than a colon, would > > also make more sense: > > > > --author '%s' is

Re: [PATCHv2] commit: reword --author error message

2015-01-26 Thread Junio C Hamano
Jeff King writes: > ... I somehow had trouble making > sense of Z ("a match...") as a noun. > I wonder if adding back in the missing verb, rather than a colon, would > also make more sense: > > --author '%s' is neither 'Name ' nor a match for an existing author Then > --author '%s' is not

Re: [PATCHv2] commit: reword --author error message

2015-01-26 Thread Jeff King
On Mon, Jan 26, 2015 at 04:48:33PM +0100, Michael J Gruber wrote: > - die(_("No existing author found with '%s'"), name); > + die(_("--author '%s': neither 'Name ' nor a match for an > existing author"), name); I had to add to the bikeshed, but I had to read this several times to make se