Re: [PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction

2014-05-16 Thread Ronnie Sahlberg
On Fri, May 16, 2014 at 8:02 AM, Ronnie Sahlberg wrote: > On Thu, May 15, 2014 at 5:20 PM, Jonathan Nieder wrote: >> Ronnie Sahlberg wrote: >> >>> Change ref_transaction_commit so that it does not free the transaction. >>> Instead require that a caller will end a transaction by either calling >>>

Re: [PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction

2014-05-16 Thread Ronnie Sahlberg
On Thu, May 15, 2014 at 5:20 PM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> Change ref_transaction_commit so that it does not free the transaction. >> Instead require that a caller will end a transaction by either calling >> ref_transaction_rollback or ref_transaction_free. > > Can I alw

Re: [PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction

2014-05-15 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Change ref_transaction_commit so that it does not free the transaction. > Instead require that a caller will end a transaction by either calling > ref_transaction_rollback or ref_transaction_free. Can I always use ref_transaction_rollback instead of ref_transaction_free?