Re: [PATCH v8 0/3]

2019-03-13 Thread Nickolai Belakovski
> > Patch 1 looks good to me. Given that we're on v8 and most of the other > comments are for patches 2 and 3, I think we might consider graduating > it separately if the other two are not ready soon. It's independently > useful, IMHO. Patch 2 was my main motivation, so it would be nice to get it

Re: [PATCH v8 0/3]

2019-02-21 Thread Jeff King
On Tue, Feb 19, 2019 at 05:31:20PM +0900, nbelakov...@gmail.com wrote: > From: Nickolai Belakovski > > I've made the various cosmetic changes that were suggested, as well as adding > tests for 3/3 > > I don't have a particularly strong opinion on the subject of keeping the atom > as "worktree

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-21 Thread David Aguilar
On Tue, May 21, 2013 at 12:19 PM, Torsten Bögershausen wrote: > On 2013-05-21 00.52, Junio C Hamano wrote: >> Thanks, will replace da/darwin with this round. > (May be late response, not sure if this is the right email thread. > I eventually managed to compile under 10.6, what we have on pu) > > O

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-21 Thread Jonathan Nieder
Torsten Bögershausen wrote: > One minor nit, or 2: > imap-send.c: In function ‘cram’: > imap-send.c:913: warning: statement with no effect > > This fixes it: > > diff --git a/imap-send.c b/imap-send.c > index 8ea180f..11577c9 100644 > --- a/imap-send.c > +++ b/imap-send.c > @@ -35,7 +35,7 @@ typed

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-21 Thread Torsten Bögershausen
On 2013-05-21 00.52, Junio C Hamano wrote: > Thanks, will replace da/darwin with this round. (May be late response, not sure if this is the right email thread. I eventually managed to compile under 10.6, what we have on pu) One minor nit, or 2: imap-send.c: In function ‘cram’: imap-send.c:913: war

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-20 Thread Junio C Hamano
Thanks, will replace da/darwin with this round. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 0/3] submodule update: add --remote for submodule's upstream changes

2012-12-21 Thread Heiko Voigt
Hi, On Wed, Dec 19, 2012 at 11:03:30AM -0500, wk...@tremily.us wrote: > From: "W. Trevor King" > > Comments on v7 seem to have petered out, so here's v8. Changes since > v7: > > * Series based on gitster/master instead of v1.8.0. > * In Documentation/config.txt, restored trailing line of > s