Re: [PATCH v6 5/7] refs: new public ref function: safe_create_reflog

2015-07-08 Thread Michael Haggerty
On 07/08/2015 01:18 AM, David Turner wrote: > On Mon, 2015-07-06 at 18:21 +0200, Michael Haggerty wrote: > > changes applied; will re-roll. > >>> + >>> +int safe_create_reflog(const char *refname, struct strbuf *err, int >>> force_create) >>> +{ >>> + int ret; >>> + struct strbuf sb = STRBU

Re: [PATCH v6 5/7] refs: new public ref function: safe_create_reflog

2015-07-07 Thread David Turner
On Mon, 2015-07-06 at 18:21 +0200, Michael Haggerty wrote: changes applied; will re-roll. > > + > > +int safe_create_reflog(const char *refname, struct strbuf *err, int > > force_create) > > +{ > > + int ret; > > + struct strbuf sb = STRBUF_INIT; > > + > > + ret = log_ref_setup(refname, &

Re: [PATCH v6 5/7] refs: new public ref function: safe_create_reflog

2015-07-06 Thread Michael Haggerty
On 06/29/2015 10:17 PM, David Turner wrote: > The safe_create_reflog function creates a reflog, if it does not > already exist. > > The log_ref_setup function becomes private and gains a force_create > parameter to force the creation of a reflog even if log_all_ref_updates > is false or the refnam