Re: [PATCH v6 31/44] run-command: make dup_devnull() non static

2016-06-11 Thread Christian Couder
On Sat, Jun 11, 2016 at 10:17 AM, Johannes Sixt wrote: > Am 10.06.2016 um 22:11 schrieb Christian Couder: >> >> --- a/run-command.c >> +++ b/run-command.c >> @@ -85,7 +85,7 @@ static inline void close_pair(int fd[2]) >> } >> >> #ifndef GIT_WINDOWS_NATIVE >> -static inline void dup_devnull(int

Re: [PATCH v6 31/44] run-command: make dup_devnull() non static

2016-06-11 Thread Johannes Sixt
Am 10.06.2016 um 22:11 schrieb Christian Couder: --- a/run-command.c +++ b/run-command.c @@ -85,7 +85,7 @@ static inline void close_pair(int fd[2]) } #ifndef GIT_WINDOWS_NATIVE -static inline void dup_devnull(int to) +void dup_devnull(int to) I'm not adding arguments to what we've heard on