Re: [PATCH v6 01/11] grep: allow -F -i combination

On Sat, Jun 18, 2016 at 4:54 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> -F means "no regex", not "case sensitive" so it should not override -i > > That logic is flawed, isn't it? > > "-F" means "no regex", so it should not touch opt.regflags at all. > >> Signed-off-by: Nguyễn

Re: [PATCH v6 01/11] grep: allow -F -i combination

Nguyễn Thái Ngọc Duy writes: > -F means "no regex", not "case sensitive" so it should not override -i That logic is flawed, isn't it? "-F" means "no regex", so it should not touch opt.regflags at all. > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/grep.c | 2 +- > 1 file changed, 1 i