Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-07-08 Thread Christian Couder
On Fri, Jul 7, 2017 at 8:35 PM, Junio C Hamano wrote: > Ben Peart writes: > >> On 6/14/2017 2:36 PM, Junio C Hamano wrote: >>> Ben Peart writes: >>> > Having said all that, I think you are using this ONLY on windows; > perhaps it is better to drop #ifdef GIT_WINDOWS_NATIVE from all of >>

RE: [PATCH v5 7/7] fsmonitor: add a performance test

2017-07-07 Thread David Turner
ner ; > p...@peff.net; christian.cou...@gmail.com; ava...@gmail.com > Subject: Re: [PATCH v5 7/7] fsmonitor: add a performance test > > Ben Peart writes: > > > On 6/14/2017 2:36 PM, Junio C Hamano wrote: > >> Ben Peart writes: > >> > >>>> Having s

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-07-07 Thread Ben Peart
On 7/7/2017 2:35 PM, Junio C Hamano wrote: Ben Peart writes: On 6/14/2017 2:36 PM, Junio C Hamano wrote: Ben Peart writes: Having said all that, I think you are using this ONLY on windows; perhaps it is better to drop #ifdef GIT_WINDOWS_NATIVE from all of the above and arrange Makefile t

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-07-07 Thread Junio C Hamano
Ben Peart writes: > On 6/14/2017 2:36 PM, Junio C Hamano wrote: >> Ben Peart writes: >> Having said all that, I think you are using this ONLY on windows; perhaps it is better to drop #ifdef GIT_WINDOWS_NATIVE from all of the above and arrange Makefile to build test-drop-cache only

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-07-07 Thread Ben Peart
On 6/14/2017 2:36 PM, Junio C Hamano wrote: Ben Peart writes: Having said all that, I think you are using this ONLY on windows; perhaps it is better to drop #ifdef GIT_WINDOWS_NATIVE from all of the above and arrange Makefile to build test-drop-cache only on that platform, or something? I

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-06-14 Thread Junio C Hamano
Ben Peart writes: >> Having said all that, I think you are using this ONLY on windows; >> perhaps it is better to drop #ifdef GIT_WINDOWS_NATIVE from all of >> the above and arrange Makefile to build test-drop-cache only on that >> platform, or something? > > I didn't find any other examples of W

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-06-14 Thread Ben Peart
On 6/12/2017 6:04 PM, Junio C Hamano wrote: Ben Peart writes: diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c new file mode 100644 index 00..80830d920b --- /dev/null +++ b/t/helper/test-drop-caches.c @@ -0,0 +1,107 @@ +#include "git-compat-util.h" +#include

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-06-12 Thread Junio C Hamano
Ben Peart writes: > diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c > new file mode 100644 > index 00..80830d920b > --- /dev/null > +++ b/t/helper/test-drop-caches.c > @@ -0,0 +1,107 @@ > +#include "git-compat-util.h" > +#include I thought compat-util should alrea

Re: [PATCH v5 7/7] fsmonitor: add a performance test

2017-06-10 Thread Ben Peart
Here are some perf test results for repos of various size generated with many-files.sh. Comparing cold fs cache times on a fast SSD running Windows: # files preloadindexfsmonitor reduction = 10,000 0.69