Re: [PATCH v5 10/40] Add initial external odb support

On Thu, Aug 3, 2017 at 9:34 PM, Junio C Hamano wrote: > Christian Couder writes: > >> diff --git a/external-odb.h b/external-odb.h >> new file mode 100644 >> index 00..9989490c9e >> --- /dev/null >> +++ b/external-odb.h >> @@ -0,0 +1,8 @@ >> +#ifndef EXTERNAL_ODB_H >> +#define EXTERNAL_OD

Re: [PATCH v5 10/40] Add initial external odb support

On Thu, Aug 03, 2017 at 12:34:25PM -0700, Junio C Hamano wrote: > > +int external_odb_get_object(const unsigned char *sha1) > > +{ > > + struct odb_helper *o; > > + const char *path; > > + > > + if (!external_odb_has_object(sha1)) > > + return -1; > > This probably would not matte

Re: [PATCH v5 10/40] Add initial external odb support

Christian Couder writes: > +int external_odb_has_object(const unsigned char *sha1) > +{ > + struct odb_helper *o; > + > + external_odb_init(); > + > + for (o = helpers; o; o = o->next) > + if (odb_helper_has_object(o, sha1)) > + return 1; > + return