Re: [PATCH v4 4/6] revision: implement sparse algorithm

2019-01-11 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > When enumerating objects to place in a pack-file during 'git > pack-objects --revs', we discover the "frontier" of commits > that we care about and the boundary with commit we find > uninteresting. From that point, we walk tree

Re: [PATCH v4 4/6] revision: implement sparse algorithm

2018-12-17 Thread Derrick Stolee
On 12/17/2018 9:26 AM, Ævar Arnfjörð Bjarmason wrote: On Mon, Dec 17 2018, Derrick Stolee wrote: As for adding progress to this step, I'm open to it. It can be done as a sequel series. Okey. To clarify I wasn't complaining about the lack of progress output, we didn't have it before, just clar

Re: [PATCH v4 4/6] revision: implement sparse algorithm

2018-12-17 Thread Ævar Arnfjörð Bjarmason
On Mon, Dec 17 2018, Derrick Stolee wrote: > On 12/14/2018 6:32 PM, Ævar Arnfjörð Bjarmason wrote: >> On Fri, Dec 14 2018, Derrick Stolee via GitGitGadget wrote: >> >>> Despite these potential drawbacks, the benefits of the algorithm >>> are clear. By adding a counter to 'add_children_by_path' a

Re: [PATCH v4 4/6] revision: implement sparse algorithm

2018-12-17 Thread Derrick Stolee
On 12/14/2018 6:32 PM, Ævar Arnfjörð Bjarmason wrote: On Fri, Dec 14 2018, Derrick Stolee via GitGitGadget wrote: Despite these potential drawbacks, the benefits of the algorithm are clear. By adding a counter to 'add_children_by_path' and 'mark_tree_contents_uninteresting', I measured the numb

Re: [PATCH v4 4/6] revision: implement sparse algorithm

2018-12-14 Thread Ævar Arnfjörð Bjarmason
On Fri, Dec 14 2018, Derrick Stolee via GitGitGadget wrote: > Despite these potential drawbacks, the benefits of the algorithm > are clear. By adding a counter to 'add_children_by_path' and > 'mark_tree_contents_uninteresting', I measured the number of > parsed trees for the two algorithms in a