Re: [PATCH v4 2/2] convert: ce_compare_data() checks for a sha1 of a path

2016-05-18 Thread Torsten Bögershausen
On 18.05.16 06:26, Torsten Bögershausen wrote: > On 05/17/2016 08:58 PM, Junio C Hamano wrote: >> tbo...@web.de writes: >> >>> #define HASH_WRITE_OBJECT 1 >>> #define HASH_FORMAT_CHECK 2 >>> +#define HASH_CE_HAS_SHA1 4 >> >> How does one pronounce the words in this constant? Does it make a >>

Re: [PATCH v4 2/2] convert: ce_compare_data() checks for a sha1 of a path

2016-05-17 Thread Torsten Bögershausen
On 05/17/2016 08:58 PM, Junio C Hamano wrote: tbo...@web.de writes: #define HASH_WRITE_OBJECT 1 #define HASH_FORMAT_CHECK 2 +#define HASH_CE_HAS_SHA1 4 How does one pronounce the words in this constant? Does it make a listener understand what this constant means? How about HASH_USE_SHA

Re: [PATCH v4 2/2] convert: ce_compare_data() checks for a sha1 of a path

2016-05-17 Thread Junio C Hamano
tbo...@web.de writes: > #define HASH_WRITE_OBJECT 1 > #define HASH_FORMAT_CHECK 2 > +#define HASH_CE_HAS_SHA1 4 How does one pronounce the words in this constant? Does it make a listener understand what this constant means? /* * We need a comment around here to say what these two * parame