Re: [PATCH v4 08/14] commit-graph: add --split option to builtin

2019-06-11 Thread Junio C Hamano
Derrick Stolee writes: > I think the more correct thing to say is that `--split` implies `--append`: > As we write a new tip graph, we do not discard any commits from the lower > layers, even if we merge them together. > ... > There is nothing that stops them both from being specified, so this >

Re: [PATCH v4 08/14] commit-graph: add --split option to builtin

2019-06-11 Thread Derrick Stolee
On 6/7/2019 5:57 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> -N_("git commit-graph write [--object-dir ] [--append] >> [--reachable|--stdin-packs|--stdin-commits]"), >> +N_("git commit-graph write [--object-dir ] [--append|--split] >> [--reachable|--stdin-

Re: [PATCH v4 08/14] commit-graph: add --split option to builtin

2019-06-07 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > - N_("git commit-graph write [--object-dir ] [--append] > [--reachable|--stdin-packs|--stdin-commits]"), > + N_("git commit-graph write [--object-dir ] [--append|--split] > [--reachable|--stdin-packs|--stdin-commits]"), Not a comment on the e