Re: [PATCH v4 07/10] submodule init: initialize active submodules

2017-03-17 Thread Stefan Beller
>> Here we also need to have >> >> git_config(submodule_config, NULL); >> >> such that is_submodule_initialized works correctly, >> I would assume? > > No I don't think so. is_submodule_initialized doesn't need them to be > overlayed, it just needs the .gitmodules mappings. ok, thanks! I assume

Re: [PATCH v4 07/10] submodule init: initialize active submodules

2017-03-17 Thread Brandon Williams
On 03/17, Stefan Beller wrote: > On Thu, Mar 16, 2017 at 3:29 PM, Brandon Williams wrote: > > Teach `submodule init` to initialize submodules which have been > > configured to be active by setting 'submodule.active' with a pathspec. > > > > Now if no path arguments are given and 'submodule.active'

Re: [PATCH v4 07/10] submodule init: initialize active submodules

2017-03-17 Thread Stefan Beller
On Thu, Mar 16, 2017 at 3:29 PM, Brandon Williams wrote: > Teach `submodule init` to initialize submodules which have been > configured to be active by setting 'submodule.active' with a pathspec. > > Now if no path arguments are given and 'submodule.active' is configured, > `init` will initialize