Re: [PATCH v4 01/11] pack-objects: a bit of document about struct object_entry

2018-03-17 Thread Duy Nguyen
On Fri, Mar 16, 2018 at 9:32 PM, Junio C Hamano wrote: >> +/* >> + * basic object info >> + * - >> + * idx.oid is filled up before delta searching starts. idx.crc32 and >> + * is only valid after the object is written out and will be used for > > "and is"? There was another field

Re: [PATCH v4 01/11] pack-objects: a bit of document about struct object_entry

2018-03-16 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > The role of this comment block becomes more important after we shuffle > fields around to shrink this struct. It will be much harder to see what > field is related to what. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > pack-objects.h | 44 ++