Re: [PATCH v4] pkt-line: allow writing of LARGE_PACKET_MAX buffers

2014-12-10 Thread Jeff King
On Wed, Dec 10, 2014 at 03:14:17PM -0500, Eric Sunshine wrote: > > +test_expect_success 'try to create repo with absurdly long refname' ' > > + ref240=$_z40/$_z40/$_z40/$_z40/$_z40/$_z40 > > Maybe you want to keep the &&-chain intact here? Thanks, yeah. It doesn't matter in practice, but w

Re: [PATCH v4] pkt-line: allow writing of LARGE_PACKET_MAX buffers

2014-12-10 Thread Eric Sunshine
On Wed, Dec 10, 2014 at 4:47 AM, Jeff King wrote: > Subject: pkt-line: allow writing of LARGE_PACKET_MAX buffers > > When we send out pkt-lines with refnames, we use a static > 1000-byte buffer. This means that the maximum size of a ref > over the git protocol is around 950 bytes (the exact size >

Re: [PATCH v4] pkt-line: allow writing of LARGE_PACKET_MAX buffers

2014-12-10 Thread Eric Sunshine
On Wed, Dec 10, 2014 at 4:47 AM, Jeff King wrote: > On Wed, Dec 10, 2014 at 03:36:31AM -0500, Eric Sunshine wrote: > >> On Wed, Dec 10, 2014 at 2:34 AM, Jeff King wrote: >> > Below is a another iteration on the patch. The actual code changes are >> > the same as the strbuf one, but the tests take