Re: [PATCH v3 5/6] rebase -i: support --ignore-date

2019-08-20 Thread Phillip Wood
On 20/08/2019 18:42, Junio C Hamano wrote: Rohit Ashiwal writes: +/* Construct a free()able author string with current time as the author date */ +static char *ignore_author_date(const char *author) +{ + int len = strlen(author); Mental note: ignore_author_date() would not allow author

Re: [PATCH v3 5/6] rebase -i: support --ignore-date

2019-08-20 Thread Junio C Hamano
Rohit Ashiwal writes: > +/* Construct a free()able author string with current time as the author date > */ > +static char *ignore_author_date(const char *author) > +{ > + int len = strlen(author); Mental note: ignore_author_date() would not allow author==NULL as its input. > @@ -1020,10 +1

Re: [PATCH v3 5/6] rebase -i: support --ignore-date

2019-08-20 Thread Phillip Wood
Hi Rohit On 20/08/2019 04:45, Rohit Ashiwal wrote: rebase am already has this flag to "lie" about the author date by changing it to the committer (current) date. Let's add the same for interactive machinery. Signed-off-by: Rohit Ashiwal --- Documentation/git-rebase.txt| 6 +--