Re: [PATCH v3 3/4] builtin/verify-tag: move verification code to tag.c

2016-04-03 Thread Santiago Torres
On Sun, Apr 03, 2016 at 04:19:26AM -0400, Eric Sunshine wrote: > On Sat, Apr 2, 2016 at 7:16 PM, wrote: > > The PGP verification routine for tags could be accessed by other > > commands that require it. We do this by moving it to the common tag.c > > code. We rename the verify_tag() function to p

Re: [PATCH v3 3/4] builtin/verify-tag: move verification code to tag.c

2016-04-03 Thread Eric Sunshine
On Sat, Apr 2, 2016 at 7:16 PM, wrote: > The PGP verification routine for tags could be accessed by other > commands that require it. We do this by moving it to the common tag.c > code. We rename the verify_tag() function to pgp_verify_tag() to avoid > conflicts with the mktag.c function. > > Sig

Re: [PATCH v3 3/4] builtin/verify-tag: move verification code to tag.c

2016-04-03 Thread Eric Sunshine
On Sun, Apr 3, 2016 at 12:45 AM, Jeff King wrote: > On Sat, Apr 02, 2016 at 07:16:14PM -0400, santi...@nyu.edu wrote: >> - len = parse_signature(buf, size); >> - >> - if (size == len) { >> - if (flags & GPG_VERIFY_VERBOSE) >> - write_in_full(1, buf, len); >>

Re: [PATCH v3 3/4] builtin/verify-tag: move verification code to tag.c

2016-04-02 Thread Jeff King
On Sat, Apr 02, 2016 at 07:16:14PM -0400, santi...@nyu.edu wrote: > From: Santiago Torres > > The PGP verification routine for tags could be accessed by other > commands that require it. We do this by moving it to the common tag.c > code. We rename the verify_tag() function to pgp_verify_tag() t