Re: [PATCH v3 3/4] batch check whether submodule needs pushing into one call

2016-11-16 Thread Heiko Voigt
On Tue, Nov 15, 2016 at 02:28:31PM -0800, Stefan Beller wrote: > On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt wrote: > > > -static int submodule_needs_pushing(const char *path, const unsigned char > > sha1[20]) > > +static int check_has_commit(const unsigned char sha1[20], void *data) > > { > >

Re: [PATCH v3 3/4] batch check whether submodule needs pushing into one call

2016-11-15 Thread Stefan Beller
On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt wrote: > -static int submodule_needs_pushing(const char *path, const unsigned char > sha1[20]) > +static int check_has_commit(const unsigned char sha1[20], void *data) > { > - if (add_submodule_odb(path) || !lookup_commit_reference(sha1)) > +