Re: [PATCH v3 2/9] t3701: indent here documents

2018-03-01 Thread Junio C Hamano
Phillip Wood writes: > Thanks for the tips, tbdiff looks useful (I just need to learn to read > diffs of diffs!). I also find rebasing them on a common ancestor useful > but its a bit tedious. Yes, comparing two versions of a series is somewhat unusual and needs getting used to before one can do

Re: [PATCH v3 2/9] t3701: indent here documents

2018-03-01 Thread Phillip Wood
Hi Junio On 28/02/18 15:37, Junio C Hamano wrote: > Phillip Wood writes: > >> Is there an easy way for contributors to compare the branch they post to >> what ends up it pu? > > Distributed work is pretty much symmetric, so it can be done the > same way as one would review a rerolled series by

Re: [PATCH v3 2/9] t3701: indent here documents

2018-02-28 Thread Junio C Hamano
Phillip Wood writes: > Is there an easy way for contributors to compare the branch they post to > what ends up it pu? Distributed work is pretty much symmetric, so it can be done the same way as one would review a rerolled series by another co-worker. $ git log --oneline --first-parent origin/

Re: [PATCH v3 2/9] t3701: indent here documents

2018-02-28 Thread Phillip Wood
On 27/02/18 22:35, Junio C Hamano wrote: > Phillip Wood writes: > >> From: Phillip Wood >> >> Indent here documents in line with the current style for tests. >> >> Signed-off-by: Phillip Wood >> --- > > This loses the hand-edit-while-queuing done based on Eric's comment > for the previous roun

Re: [PATCH v3 2/9] t3701: indent here documents

2018-02-27 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > Indent here documents in line with the current style for tests. > > Signed-off-by: Phillip Wood > --- This loses the hand-edit-while-queuing done based on Eric's comment for the previous round (see what has been queued on 'pu' for quite a while), w