Re: [PATCH v3 16/25] sequencer: support amending commits

2016-10-18 Thread Junio C Hamano
Johannes Schindelin writes: > On Mon, 17 Oct 2016, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > This teaches the run_git_commit() function to take an argument that will >> > allow us to implement "todo" commands that need to amend the commit >> > messages ("fixup", "squash" an

Re: [PATCH v3 16/25] sequencer: support amending commits

2016-10-18 Thread Johannes Schindelin
Hi Junio, On Mon, 17 Oct 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > This teaches the run_git_commit() function to take an argument that will > > allow us to implement "todo" commands that need to amend the commit > > messages ("fixup", "squash" and "reword"). > > Likewise

Re: [PATCH v3 16/25] sequencer: support amending commits

2016-10-17 Thread Junio C Hamano
Johannes Schindelin writes: > This teaches the run_git_commit() function to take an argument that will > allow us to implement "todo" commands that need to amend the commit > messages ("fixup", "squash" and "reword"). Likewise to 15/25, i.e. Good, though the growth by these two steps starts to m