Re: [PATCH v3 1/4] pack-protocol.txt: accept error packets in any context

2018-12-20 Thread Jeff King
On Wed, Dec 19, 2018 at 03:30:05PM -0800, Josh Steadmon wrote: > > > > This is outside of the Git pack protocol so having a separate parsing > > > > mode makes sense to me. > > > > > > This sounds like it could be a significant refactoring. Should we go > > > back to V2 of this series, and then w

Re: [PATCH v3 1/4] pack-protocol.txt: accept error packets in any context

2018-12-19 Thread Josh Steadmon
On 2018.12.17 16:33, Jeff King wrote: > On Thu, Dec 13, 2018 at 02:18:26PM -0800, Josh Steadmon wrote: > > > On 2018.12.12 17:17, Masaya Suzuki wrote: > > > On Wed, Dec 12, 2018 at 3:02 AM Jeff King wrote: > > > > This ERR handling has been moved to a very low level. What happens if > > > > we're

Re: [PATCH v3 1/4] pack-protocol.txt: accept error packets in any context

2018-12-17 Thread Jeff King
On Thu, Dec 13, 2018 at 02:18:26PM -0800, Josh Steadmon wrote: > On 2018.12.12 17:17, Masaya Suzuki wrote: > > On Wed, Dec 12, 2018 at 3:02 AM Jeff King wrote: > > > This ERR handling has been moved to a very low level. What happens if > > > we're passing arbitrary data via the packet_read() code

Re: [PATCH v3 1/4] pack-protocol.txt: accept error packets in any context

2018-12-13 Thread Josh Steadmon
On 2018.12.12 17:17, Masaya Suzuki wrote: > On Wed, Dec 12, 2018 at 3:02 AM Jeff King wrote: > > This ERR handling has been moved to a very low level. What happens if > > we're passing arbitrary data via the packet_read() code? Could we > > erroneously trigger an error if a packfile happens to hav

Re: [PATCH v3 1/4] pack-protocol.txt: accept error packets in any context

2018-12-13 Thread Jeff King
On Wed, Dec 12, 2018 at 05:17:01PM -0800, Masaya Suzuki wrote: > > This is a change in the spec with an accompanying change in the code, > > which raises the question: what do other implementations do with this > > change (both older Git, and implementations like JGit, libgit2, etc)? > > JGit is

Re: [PATCH v3 1/4] pack-protocol.txt: accept error packets in any context

2018-12-12 Thread Masaya Suzuki
On Wed, Dec 12, 2018 at 3:02 AM Jeff King wrote: > > On Tue, Dec 11, 2018 at 04:25:15PM -0800, Josh Steadmon wrote: > > > From: Masaya Suzuki > > > > In the Git pack protocol definition, an error packet may appear only in > > a certain context. However, servers can face a runtime error (e.g. I/O

Re: [PATCH v3 1/4] pack-protocol.txt: accept error packets in any context

2018-12-12 Thread Jeff King
On Tue, Dec 11, 2018 at 04:25:15PM -0800, Josh Steadmon wrote: > From: Masaya Suzuki > > In the Git pack protocol definition, an error packet may appear only in > a certain context. However, servers can face a runtime error (e.g. I/O > error) at an arbitrary timing. This patch changes the protoc