Re: [PATCH v3 1/3] t5323: test cases for git-pack-redundant

2019-01-10 Thread Junio C Hamano
SZEDER Gábor writes: >> Without `-E`, MasOS has to write two seperate sed commands, such as: >> >> git pack-redundant --all >out && >> sed -e "s#.*/pack-\(.*\)\.idx#\1#" out | \ >> sed -e "s#.*/pack-\(.*\)\.pack#\1#" Two commands, perhaps, but does it have to be two separate sed pro

Re: [PATCH v3 1/3] t5323: test cases for git-pack-redundant

2019-01-10 Thread Torsten Bögershausen
On 10.01.19 12:57, SZEDER Gábor wrote: > On Thu, Jan 10, 2019 at 11:28:34AM +0800, Jiang Xin wrote: >> SZEDER Gábor 于2019年1月9日周三 下午8:56写道: + sed -e "s#^.*/pack-\(.*\)\.\(idx\|pack\)#\1#g" | \ >>> >>> This sed command doesn't seem to work on macOS (on Travis CI), and >>> causes the

Re: [PATCH v3 1/3] t5323: test cases for git-pack-redundant

2019-01-10 Thread SZEDER Gábor
On Thu, Jan 10, 2019 at 11:28:34AM +0800, Jiang Xin wrote: > SZEDER Gábor 于2019年1月9日周三 下午8:56写道: > > > + sed -e "s#^.*/pack-\(.*\)\.\(idx\|pack\)#\1#g" | \ > > > > This sed command doesn't seem to work on macOS (on Travis CI), and > > causes the test to fail with: > > > > It works if

Re: [PATCH v3 1/3] t5323: test cases for git-pack-redundant

2019-01-09 Thread Johannes Sixt
Am 10.01.19 um 04:28 schrieb Jiang Xin: SZEDER Gábor 于2019年1月9日周三 下午8:56写道: Use something like find .git/objects -type f | grep -v pack >out && test_must_be_empty out instead, so we get an informative error message on failure. if `grep -v pack` return empty output, it will return erro

Re: [PATCH v3 1/3] t5323: test cases for git-pack-redundant

2019-01-09 Thread Jiang Xin
SZEDER Gábor 于2019年1月9日周三 下午8:56写道: > > On Wed, Jan 02, 2019 at 12:34:54PM +0800, Jiang Xin wrote: > > From: Jiang Xin > > +test_description='git redundant test' > > s/redundant/pack-redundant/ ? Yes, will correct it. > > + > > +. ./test-lib.sh > > + > > +create_commits() > > +{ > > + set -

Re: [PATCH v3 1/3] t5323: test cases for git-pack-redundant

2019-01-09 Thread SZEDER Gábor
On Wed, Jan 09, 2019 at 01:56:28PM +0100, SZEDER Gábor wrote: > On Wed, Jan 02, 2019 at 12:34:54PM +0800, Jiang Xin wrote: > > +cat >expected < > +P1:$P1 > > +P4:$P4 > > +P5:$P5 > > +P6:$P6 > > +EOF Creating the expected results could be moved into the test_expect_success block as well. > > + > >

Re: [PATCH v3 1/3] t5323: test cases for git-pack-redundant

2019-01-09 Thread SZEDER Gábor
On Wed, Jan 02, 2019 at 12:34:54PM +0800, Jiang Xin wrote: > From: Jiang Xin > > Add test cases for git pack-redundant to validate new algorithm for git > pack-redundant. > > Signed-off-by: Jiang Xin > --- > t/t5323-pack-redundant.sh | 84 > +++ > 1