2014-03-17 12:29 GMT-04:00 Michael Haggerty :
> This hunk uses the magic number "11" a couple lines later. Junio (I
> think rightly) objected [1] to rewrites in these circumstances because
> they make it even less obvious where the constant came from and thereby
> make the complete elimination of
Quint,
Thanks for v3 of the patch and for sticking with it. See a few comments
below.
On 03/15/2014 05:39 PM, Quint Guvernator wrote:
> memcmp() is replaced with negated starts_with() when comparing strings
> from the beginning and when it is logical to do so. starts_with() looks
> nicer and it
2 matches
Mail list logo
