Re: [PATCH v3 09/11] t4014: more tests about appending s-o-b lines

2013-01-27 Thread Junio C Hamano
Junio C Hamano writes: >> Is "grep -n" portable? I didn't find any uses of it elsewhere in the >> testsuite. > > Yes, "-n" is in POSIX. Even though we use it ourselves, "git grep" > supports it, too. Ehh even though we *DONT* use it ourselves, ... that is. I do not think we mind, if its use h

Re: [PATCH v3 09/11] t4014: more tests about appending s-o-b lines

2013-01-27 Thread Junio C Hamano
Jonathan Nieder writes: > Brandon Casey wrote: > > [...] >> --- a/t/t4014-format-patch.sh >> +++ b/t/t4014-format-patch.sh >> @@ -1021,4 +1021,246 @@ test_expect_success 'cover letter using branch >> description (6)' ' >> grep hello actual >/dev/null >> ' >> >> +append_signoff() >> +{ >>

Re: [PATCH v3 09/11] t4014: more tests about appending s-o-b lines

2013-01-27 Thread Jonathan Nieder
Brandon Casey wrote: [...] > --- a/t/t4014-format-patch.sh > +++ b/t/t4014-format-patch.sh > @@ -1021,4 +1021,246 @@ test_expect_success 'cover letter using branch > description (6)' ' > grep hello actual >/dev/null > ' > > +append_signoff() > +{ > + C=`git commit-tree HEAD^^{tree} -