Re: [PATCH v3 04/20] repository: introduce the repository object

2017-06-21 Thread Stefan Beller
>> I guess we can still refactor later, it's just one >> thing to thing about when introducing an API >> that will likely be used a lot down the road. > > I'm not sure what we want right now, hence why I left it a little more > vague. At this point in time all the relevant callers I can think of >

Re: [PATCH v3 04/20] repository: introduce the repository object

2017-06-21 Thread Brandon Williams
On 06/20, Stefan Beller wrote: > On Tue, Jun 20, 2017 at 12:19 PM, Brandon Williams wrote: > > Introduce the repository object 'struct repository' which can be used to > > hold all state pertaining to a git repository. > > > > Some of the benefits of object-ifying a repository are: > > > > 1. Ma

Re: [PATCH v3 04/20] repository: introduce the repository object

2017-06-20 Thread Brandon Williams
On 06/20, Jonathan Tan wrote: > On Tue, 20 Jun 2017 12:19:35 -0700 > Brandon Williams wrote: > > > Introduce the repository object 'struct repository' which can be used to > > hold all state pertaining to a git repository. > > > > Some of the benefits of object-ifying a repository are: > > > >

Re: [PATCH v3 04/20] repository: introduce the repository object

2017-06-20 Thread Jonathan Tan
On Tue, 20 Jun 2017 12:19:35 -0700 Brandon Williams wrote: > Introduce the repository object 'struct repository' which can be used to > hold all state pertaining to a git repository. > > Some of the benefits of object-ifying a repository are: > > 1. Make the code base more readable and easier

Re: [PATCH v3 04/20] repository: introduce the repository object

2017-06-20 Thread Stefan Beller
On Tue, Jun 20, 2017 at 12:19 PM, Brandon Williams wrote: > Introduce the repository object 'struct repository' which can be used to > hold all state pertaining to a git repository. > > Some of the benefits of object-ifying a repository are: > > 1. Make the code base more readable and easier to