Re: [PATCH v3 0/9] Let log-tree and friends respect diffopt's `file` field

2016-06-22 Thread Paul Tan
Hi Johannes, On Tue, Jun 21, 2016 at 10:12 PM, Johannes Schindelin wrote: > Hi Paul, > > On Tue, 21 Jun 2016, Paul Tan wrote: > >> On Tue, Jun 21, 2016 at 6:34 PM, Johannes Schindelin >> wrote: >> > - this uncovered a problem with builtin am, where it asked the diff >> > machinery to close the

Re: [PATCH v3 0/9] Let log-tree and friends respect diffopt's `file` field

2016-06-21 Thread Johannes Schindelin
Hi Paul, On Tue, 21 Jun 2016, Paul Tan wrote: > On Tue, Jun 21, 2016 at 6:34 PM, Johannes Schindelin > wrote: > > - this uncovered a problem with builtin am, where it asked the diff > > machinery to close the file stream, but actually called the log_tree > > machinery (which might mean that

Re: [PATCH v3 0/9] Let log-tree and friends respect diffopt's `file` field

2016-06-21 Thread Paul Tan
Hi Johannes, On Tue, Jun 21, 2016 at 6:34 PM, Johannes Schindelin wrote: > - this uncovered a problem with builtin am, where it asked the diff > machinery to close the file stream, but actually called the log_tree > machinery (which might mean that this patch series inadvertently fixes > a