Re: [PATCH v3 0/3] deprecate git stash save

On Mon, 23 Oct 2017, Junio C Hamano wrote: > Thomas Gummerer writes: > > > Interdiff below: > > Thanks. Looks much more polished. > > > > > diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt > > index 89b6a0e672..8be661007d 100644 > > --- a/Documentation/git-stash.txt > > +++

Re: [PATCH v3 0/3] deprecate git stash save

Jeff King writes: > On Mon, Oct 23, 2017 at 10:19:38AM +0900, Junio C Hamano wrote: > >> > - This option is deprecated in favour of 'git stash push'. >> > + This option is deprecated in favour of 'git stash push'. It >> > + differs from "stash push" in that it cannot take pathspecs, >> > + a

Re: [PATCH v3 0/3] deprecate git stash save

On Mon, Oct 23, 2017 at 10:19:38AM +0900, Junio C Hamano wrote: > > - This option is deprecated in favour of 'git stash push'. > > + This option is deprecated in favour of 'git stash push'. It > > + differs from "stash push" in that it cannot take pathspecs, > > + and any non-option argum

Re: [PATCH v3 0/3] deprecate git stash save

Overall the result looks reasonable and get us closer to the ideal world where nobody recalls "stash save" has ever existed ;-) Will queue; thanks.

Re: [PATCH v3 0/3] deprecate git stash save

Thomas Gummerer writes: > Interdiff below: Thanks. Looks much more polished. > > diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt > index 89b6a0e672..8be661007d 100644 > --- a/Documentation/git-stash.txt > +++ b/Documentation/git-stash.txt > @@ -86,7 +86,9 @@ The `--patch

Re: [PATCH v3 0/3] deprecate git stash save

On Sun, Oct 22, 2017 at 06:04:06PM +0100, Thomas Gummerer wrote: > Thanks Peff for the review of the previous rounds. > > In addition to addressing the review comments, this round adds another > patch getting rid of the extra help with an unknown option to git > stash push. Yeah, the reasoning i