Re: [PATCH v3] pkt-line: allow writing of LARGE_PACKET_MAX buffers

2014-12-10 Thread Jeff King
On Wed, Dec 10, 2014 at 04:49:38AM -0500, Eric Sunshine wrote: > On Wed, Dec 10, 2014 at 4:42 AM, Eric Sunshine > wrote: > > On Wed, Dec 10, 2014 at 3:36 AM, Eric Sunshine > > wrote: > >> On Wed, Dec 10, 2014 at 2:34 AM, Jeff King wrote: > >>> Below is a another iteration on the patch. The ac

Re: [PATCH v3] pkt-line: allow writing of LARGE_PACKET_MAX buffers

2014-12-10 Thread Eric Sunshine
On Wed, Dec 10, 2014 at 4:42 AM, Eric Sunshine wrote: > On Wed, Dec 10, 2014 at 3:36 AM, Eric Sunshine > wrote: >> On Wed, Dec 10, 2014 at 2:34 AM, Jeff King wrote: >>> Below is a another iteration on the patch. The actual code changes are >>> the same as the strbuf one, but the tests take care

Re: [PATCH v3] pkt-line: allow writing of LARGE_PACKET_MAX buffers

2014-12-10 Thread Eric Sunshine
On Wed, Dec 10, 2014 at 3:36 AM, Eric Sunshine wrote: > On Wed, Dec 10, 2014 at 2:34 AM, Jeff King wrote: >> Below is a another iteration on the patch. The actual code changes are >> the same as the strbuf one, but the tests take care to avoid assuming >> the filesystem can handle such a long pat

Re: [PATCH v3] pkt-line: allow writing of LARGE_PACKET_MAX buffers

2014-12-10 Thread Eric Sunshine
On Wed, Dec 10, 2014 at 2:34 AM, Jeff King wrote: > Below is a another iteration on the patch. The actual code changes are > the same as the strbuf one, but the tests take care to avoid assuming > the filesystem can handle such a long path. Testing on Windows and OS X > is appreciated. All three