Re: [PATCH v2 on ds/commit-graph-fsck 0/6] Object store refactoring: commit graph

2018-07-09 Thread Derrick Stolee
On 7/9/2018 8:30 PM, Derrick Stolee wrote: On 7/9/2018 6:27 PM, Junio C Hamano wrote: Jonathan Tan writes: This is on ds/commit-graph-fsck. I saw that ds/commit-graph-fsck has been updated to the latest version (v7, including "gc.writeCommitGraph"), so I've rebased my changes on top of t

Re: [PATCH v2 on ds/commit-graph-fsck 0/6] Object store refactoring: commit graph

2018-07-09 Thread Derrick Stolee
On 7/9/2018 6:27 PM, Junio C Hamano wrote: Jonathan Tan writes: This is on ds/commit-graph-fsck. I saw that ds/commit-graph-fsck has been updated to the latest version (v7, including "gc.writeCommitGraph"), so I've rebased my changes on top of that branch. There were some mechanical changes n

Re: [PATCH v2 on ds/commit-graph-fsck 0/6] Object store refactoring: commit graph

2018-07-09 Thread Junio C Hamano
Jonathan Tan writes: > This is on ds/commit-graph-fsck. > > I saw that ds/commit-graph-fsck has been updated to the latest version > (v7, including "gc.writeCommitGraph"), so I've rebased my changes on top > of that branch. There were some mechanical changes needed during the > rebase, so I'm sen

Re: [PATCH v2 on ds/commit-graph-fsck 0/6] Object store refactoring: commit graph

2018-07-09 Thread Stefan Beller
Hi Jonathan, > This is on ds/commit-graph-fsck. > [...] > I've also added a patch (patch 1) that removes some duplication of > implementation that Junio talked about in [1]. I think this series is good; Thanks, Stefan