Re: [PATCH v2 6/8] mv: unindent one level for directory move code

2014-08-12 Thread Junio C Hamano
Duy Nguyen writes: >> Otherwise, perhaps squash this in? > > Sure. But I'm having second thought about this series. > > mv.c is centered around files on worktree, which makes it pretty hard > if we want to make it more like rm.c where index and worktree entries > are treated more equally and path

Re: [PATCH v2 6/8] mv: unindent one level for directory move code

2014-08-12 Thread Duy Nguyen
On Tue, Aug 12, 2014 at 1:47 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> builtin/mv.c | 47 +-- >> 1 file changed, 21 insertions(+), 26 deletions(-) >> >> diff --git a/builtin/mv.c b/bui

Re: [PATCH v2 6/8] mv: unindent one level for directory move code

2014-08-11 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/mv.c | 47 +-- > 1 file changed, 21 insertions(+), 26 deletions(-) > > diff --git a/builtin/mv.c b/builtin/mv.c > index dcfcb11..988945c 100644 > --- a/builtin/mv.c >