Re: [PATCH v2 6/6] t9109-git-svn-props.sh: split up several pipes

2018-09-19 Thread Matthew DeVore
On Wed, Sep 19, 2018 at 5:50 AM Eric Sunshine wrote: > > If so, then please use test_cmp() rather than raw 'cmp' since > test_cmp() will show the actual difference between the expected and > actual files, which can be helpful when diagnosing a failing test. > All the other testcases in this file u

Re: [PATCH v2 6/6] t9109-git-svn-props.sh: split up several pipes

2018-09-19 Thread Eric Sunshine
On Tue, Sep 18, 2018 at 10:56 PM Matthew DeVore wrote: > On Mon, Sep 17, 2018 at 6:57 PM Eric Sunshine wrote: > > On Mon, Sep 17, 2018 at 6:25 PM Matthew DeVore wrote: > > > + cmp - $3 > > > > This is just wrong. The "-" argument to 'cmp' says to read from > > standard input, but t

Re: [PATCH v2 6/6] t9109-git-svn-props.sh: split up several pipes

2018-09-18 Thread Matthew DeVore
On Mon, Sep 17, 2018 at 6:57 PM Eric Sunshine wrote: > > On Mon, Sep 17, 2018 at 6:25 PM Matthew DeVore wrote: > > t9109-git-svn-props.sh: split up several pipes > > Similar to my comment about 5/6, this title talks about the mechanical > changes made by the patch but not the intent. Perhaps rewo

Re: [PATCH v2 6/6] t9109-git-svn-props.sh: split up several pipes

2018-09-17 Thread Eric Sunshine
On Mon, Sep 17, 2018 at 6:25 PM Matthew DeVore wrote: > t9109-git-svn-props.sh: split up several pipes Similar to my comment about 5/6, this title talks about the mechanical changes made by the patch but not the intent. Perhaps reword it like this: t9109: avoid swallowing Git exit code upstr