Re: [PATCH v2 5/6] builtin/grep.c: show column numbers via --column-number

On Sun, Apr 22, 2018 at 08:32:28PM -0400, Eric Sunshine wrote: > On Sun, Apr 22, 2018 at 4:47 PM, Taylor Blau wrote: > > This commit teaches 'git-grep(1)' a new option, '--column-number'. This > > option builds upon previous commits to show the column number of the > > first match on a non-context

Re: [PATCH v2 5/6] builtin/grep.c: show column numbers via --column-number

On Sun, Apr 22, 2018 at 4:47 PM, Taylor Blau wrote: > This commit teaches 'git-grep(1)' a new option, '--column-number'. This > option builds upon previous commits to show the column number of the > first match on a non-context line. Imperative mood (and dropping unnecessary "builds upon previous

Re: [PATCH v2 5/6] builtin/grep.c: show column numbers via --column-number

On Sun, Apr 22, 2018 at 11:48:53PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Sun, Apr 22 2018, Taylor Blau wrote: > > I think this part though... > > > While we're at it, change color.grep.linenumber to color.grep.lineNumber > > to match the casing of nearby variables. > > [...] > > -`linenumber

Re: [PATCH v2 5/6] builtin/grep.c: show column numbers via --column-number

On Sun, Apr 22 2018, Taylor Blau wrote: I think this part though... > While we're at it, change color.grep.linenumber to color.grep.lineNumber > to match the casing of nearby variables. > [...] > -`linenumber`;; > +`lineNumber`;; Makes sense as its own patch at the beginning of the series, sinc