Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-10-06 Thread Johannes Schindelin
Hi Junio, On 2015-10-06 00:06, Junio C Hamano wrote: > Johannes Schindelin writes: > >> Oh, I appreciate your feedback. I am actually not all *that* certain >> that removing the broken symref is the correct thing. It is this sort >> of fruitful exchange that allows me to throw out an idea and be

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-10-05 Thread Junio C Hamano
Johannes Schindelin writes: > Oh, I appreciate your feedback. I am actually not all *that* certain > that removing the broken symref is the correct thing. It is this sort > of fruitful exchange that allows me to throw out an idea and be > relatively certain that something better will come out of

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
Hi Peff, On 2015-09-28 21:03, Jeff King wrote: > On Mon, Sep 28, 2015 at 04:02:08PM +0200, Johannes Schindelin wrote: > >> @@ -136,7 +139,14 @@ int cmd_prune(int argc, const char **argv, const char >> *prefix) >> if (show_progress) >> progress = start_progress_delay(_("Checking

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Johannes Schindelin
Hi Junio, On 2015-09-28 20:49, Junio C Hamano wrote: > Junio C Hamano writes: > >> Johannes Schindelin writes: >> >>> When encountering broken symrefs, such as a stale remote HEAD (which can >>> happen if the active branch was renamed in the remote), it is more >>> helpful to remove those symre

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Jeff King
On Mon, Sep 28, 2015 at 04:02:08PM +0200, Johannes Schindelin wrote: > @@ -136,7 +139,14 @@ int cmd_prune(int argc, const char **argv, const char > *prefix) > if (show_progress) > progress = start_progress_delay(_("Checking connectivity"), 0, > 0, 2); > > - mark_reachab

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Junio C Hamano
Junio C Hamano writes: > Johannes Schindelin writes: > >> When encountering broken symrefs, such as a stale remote HEAD (which can >> happen if the active branch was renamed in the remote), it is more >> helpful to remove those symrefs than to exit with an error. > > I think this depends on the

Re: [PATCH v2 4/4] gc: remove broken symrefs

2015-09-28 Thread Junio C Hamano
Johannes Schindelin writes: > When encountering broken symrefs, such as a stale remote HEAD (which can > happen if the active branch was renamed in the remote), it is more > helpful to remove those symrefs than to exit with an error. I think this depends on the perspective. One side of me says